Skip to content

Conversation

BashirYesufu
Copy link

Description

Change Animation View to Lottie Animation View for Xcode 14 and swift 5.8 compatibility along side other recent XCode versions

Related Issue

#28

Motivation and Context

For already existing projects already integrating rave Flutterwave SDK, updating the Xcode IDE and swift version, breaks the Lottie animation from the Rave SDK

How Has This Been Tested?

This was tested in my project currently live on the store, where I had to manually go into the RaveSDK to update the animation view in order to build the project successfully.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • [ x] My code follows the code style of this project.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. This is just a rename of the lottie animation view class from the lottie
  • [x ] All new and existing tests passed.
  • [ x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Flutterwave/Corvus97 What do you think about these updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant